Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120677815. |
coado
force-pushed
the
export-D120677815
branch
from
September 18, 2026 15:45
348727d to
3f52b12
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Pull Request resolved: react#58587 Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies. Changelog: [Internal] Differential Revision: D120677815
meta-codesync
Bot
changed the title
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120532145
Summary: Pull Request resolved: react#58587 Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120677815
coado
force-pushed
the
export-D120677815
branch
from
September 21, 2026 14:37
3f52b12 to
d1832f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies.
Changelog:
[Internal]
Reviewed By: cipolleschi
Differential Revision: D120677815