Options: rename underlying_locked and quote_locked to underlying_owed and quote_owed - #173
Merged
Merged
Conversation
… and quote_owed Each field counts what the market's vault owes: collateral to writers, and settlement proceeds waiting for a writer or holder to collect them. "Locked" did not say to whom, and could read as a lock in the file-locking sense. The Quasar helpers add_locked and sub_locked become add_owed and sub_owed, and the comments and test messages that said tokens were "locked to" someone now say "owed to". The account layout is unchanged; the IDL field names change. From quicknode/solana-book#190. Claude-Session: https://claude.ai/code/session_01JGEoAUjMm7Evv69k46eNcn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each field counts what the market's vault owes: collateral to writers, and settlement proceeds waiting for a writer or holder to collect. "Locked" doesn't say to whom, and can read as a lock in the file-locking sense. The fields' own doc comments already said "the vault owes".
The renames, in Anchor, Anchor v1, Quasar and the Kani harnesses:
Market.underlying_lockedunderlying_owedMarket.quote_lockedquote_owedadd_locked/sub_lockedadd_owed/sub_owedComments and test messages that said tokens are "locked to" someone now say "owed to".
The account layout is unchanged; the IDL field names change.
Checks:
cargo fmt --checkis clean.cargo check --testspasses for all four crates.The book follows once this merges: quicknode/solana-book#190 and the Options chapter.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JGEoAUjMm7Evv69k46eNcn
Generated by Claude Code