Rename protocol fees to program fees, and "locks" test names to what they check - #171
Merged
Merged
Conversation
…y check - `protocol_fees` becomes `program_fees` in the perpetual futures pool, and `accumulated_protocol_fees` becomes `accumulated_program_fees` in the lending reserve. The lending instruction `collect_protocol_fees` becomes `collect_program_fees` (and `CollectProgramFees`), in every variant, along with the tests and the Kani harness that named them. - Test names that said an order or option "locks" tokens now say where the tokens go: `place_bid_moves_quote_into_vault`, `place_ask_moves_base_into_vault`, `test_write_call_moves_underlying_into_vault`. - Comments and READMEs that called the program "the protocol" (fees, rounding in its favour, who keeps dust) now say "the program". Mentions of the Solana protocol changing slot times are unchanged, as are CHANGELOG history entries. - "source of truth" comments now say which field the program reads. Renaming the lending instruction changes its Anchor discriminator, and renaming the account fields changes their IDL names; the byte layout is unchanged. Follows quicknode/solana-book#190, which rewrites the book's wording the same way. Claude-Session: https://claude.ai/code/session_01JGEoAUjMm7Evv69k46eNcn
Collaborator
Author
|
The I don't think this PR causes it:
No fix exists yet. I'm re-running the failed job once. If it fails again, the fix is to find which dependency moved and either pin it or re-measure the limit, in its own PR. I won't raise the limit here to get this PR green. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows quicknode/solana-book#190, which removes "protocol" and vague "lock" wording from the book. The book can only name identifiers that exist here, so the rename lands here first.
Identifiers
Pool.protocol_fees(perpetual futures, all variants)program_feesReserve.accumulated_protocol_fees(lending)accumulated_program_feescollect_protocol_fees/CollectProtocolFees/handle_collect_protocol_fees(lending)collect_program_fees/CollectProgramFees/handle_collect_program_feesprotocol_fees_accrue_and_owner_can_collect(lending tests)program_fees_accrue_and_owner_can_collectproof_rounding_is_protocol_favourable(lending Kani)proof_rounding_is_program_favourableplace_bid_locks_quote_in_vault,place_ask_locks_base_in_vault(order book)place_bid_moves_quote_into_vault,place_ask_moves_base_into_vaulttest_write_call_locks_the_underlying(options)test_write_call_moves_underlying_into_vaultRenaming the lending instruction changes its Anchor discriminator, and the account fields get new IDL names. The byte layouts are unchanged.
Prose
Checks
cargo fmt --checkis clean in every touched crate.cargo check --testspasses in every touched anchor, anchor-v1, quasar and kani-proofs crate. The Anchor ones were checked against placeholder.sofiles becausecargo-build-sbfisn't available locally, so CI runs the tests for real.🤖 Generated with Claude Code
https://claude.ai/code/session_01JGEoAUjMm7Evv69k46eNcn
Generated by Claude Code