Conversation
Documentation build overview
11 files changed ·
|
Comment on lines
+272
to
+275
| /* Persian (fa) uses Vazirmatn, since the default system font stack renders | ||
| Arabic-script text poorly on many platforms. This is scoped to :lang(fa) | ||
| rather than [dir='rtl'] so other RTL languages (Arabic, Hebrew, Urdu...) | ||
| and all LTR languages are unaffected. */ |
Member
There was a problem hiding this comment.
Suggested change
| /* Persian (fa) uses Vazirmatn, since the default system font stack renders | |
| Arabic-script text poorly on many platforms. This is scoped to :lang(fa) | |
| rather than [dir='rtl'] so other RTL languages (Arabic, Hebrew, Urdu...) | |
| and all LTR languages are unaffected. */ | |
| /* Persian (fa) uses Vazirmatn, since the default system font stack renders | |
| Arabic-script text poorly on many platforms. */ |
The rest just repeats what's below, so I suggest we drop it.
| } | ||
|
|
||
| :lang(fa) :is( | ||
| body, |
Member
There was a problem hiding this comment.
What about buttons and selects, I don't think they inherit here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Vazirmatn for Farsi builds. Vazirmatn is an open-source font licensed under the SIL Open Font License. Adding this to Farsi builds improves the readability and quality of the documentation.
I didn't touch the broader RTL fonts and kept it scoped to Farsi with
:lang(fa). The font is bundled as a single variable WOFF2 file instatic/fonts/, with itsOFL.txtalongside.With Vazirmatn:
Before:
Please let me know if any changes or additions are needed. Thanks in advance!