-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PEP 824: None-coalescing operators #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cdce8p
wants to merge
22
commits into
python:main
Choose a base branch
from
cdce8p:pep824-coalescing-operators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+609
−0
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2f2082f
PEP 824: Coalescing operators
cdce8p 17d951a
Fix typos
cdce8p b6684b7
Minor changes
cdce8p 0351b5c
Add links to reference implementation and demo
cdce8p 68d6ded
Merge branch 'main' into pep824-coalescing-operators
hugovk dbae13e
Update pep-0824.rst to target 3.16
gvanrossum d2b7b27
Merge branch 'main'
cdce8p 66f4f07
Rewrite motivation section
cdce8p 5108b5a
Extend How to Teach This section
cdce8p c5ccc62
Simplify AST for ??
cdce8p 9b59780
Improvements
cdce8p 168f173
Feedback
cdce8p 4007cbd
Minor
cdce8p 9debc5f
Minor suggestions
cdce8p 377dc67
Update motivation section after review
cdce8p 7f2e430
Minor
cdce8p c9c50e6
Add section explaining why ??= shouldn't be atomic
cdce8p 0f1ef88
Minor
cdce8p 4c00a38
Update table formatting
cdce8p 2c85f76
Nit
cdce8p 1be679f
Nit
cdce8p 4cf9f87
Spelling
cdce8p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the
# ...? If it's to fend off a merge conflict with the PR for PEP 823, I think there's a better way to do that (just fix the second PR after the first one has landed).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added in 68d6ded. I believe
# ...is used in theCODEOWNERSfile to show a missing PEP number. It's used a few times throughout the file.Tbh I don't think it really matters. Resolving the inevitable merge conflict will get rid of it.