fix dmypy namespace cache 20519 - #22009
Open
SynapShift wants to merge 2 commits into
Open
SynapShift wants to merge 2 commits into
SynapShift wants to merge 2 commits into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
SynapShift
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When dmypy reuses a fine-grained cache, a namespace-package ancestor can appear in
State.ancestorswithout having a corresponding graph node. On a later unchanged run,find_reachable_changed_modules()indexed that missing node and crashed withKeyError.Only enqueue dependencies and ancestors that are present in the graph. Add an end-to-end daemon regression test covering the original sequence: create a fine-grained cache containing an error, start dmypy from that cache, change a module below a namespace package, and run the daemon again without further changes.
Fixes #20519.
Tests
python -m pytest -o addopts='' -q "mypy/test/testdaemon.py::DaemonSuite::daemon.test::testDaemonFineGrainedCacheNamespacePackage"python -m pytest -o addopts='' -q mypy/test/testfinegrainedcache.py— 538 passed, 227 skippedpython -m ruff check mypy/dmypy_server.pypython -m ruff format --check mypy/dmypy_server.py