gh-153426: Raise BadZipFile for invalid UTF-8 filenames- #1 - #158591
Closed
williedevibes-prog wants to merge 1 commit into
Closed
williedevibes-prog wants to merge 1 commit into
williedevibes-prog wants to merge 1 commit into
Conversation
Add error handling for UTF-8 filename decoding in zipfile.
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
This PR looks like autogenerated spam so I'll just close it. If you're human wanting to learn, please ask for explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise Bad
williedevibes-prog#1 53426: Raise BadZipFile for invalid
UTF-8 filenames in zipfile
Problem
When a ZIP entry has the UTF-8 flag set
but its filename is not valid
UTF-8, zipfile raises UnicodeDecodeError
instead of BadZipFile.
Callers who catch BadZipFile for corrupt
archives miss this case.
Fix
[Describe in 1-2 sentences, e.g. "The
filename decoding in
Ziplnfo/_RealGetContents is now wrapped
so a UnicodeDecodeError is
re-raised as BadZipFile."]
Tests
Added a regression test in Lib/test/
test_zipfile/ that opens an archive
with an invalid UTF-8 filename and asserts
BadZipFile is raised.
The test failed before the change and
passes now.
Ran: python -m test test_zipfile
Before / after
Before: UnicodeDecodeError: 'utf-8' codec can't decode byte
After: zipfile.BadZipFile: File name is not valid UTF-8