gh-158494: zipimport: raise ZipImportError for corrupt deflate data - #158498
Open
Tony123-tech wants to merge 1 commit into
Open
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
Tony123-tech
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
September 30, 2026 12:40
aisk
reviewed
Sep 30, 2026
| TESTMOD + pyc_ext: badtime_pyc} | ||
| self.doTest(".py", files, TESTMOD) | ||
|
|
||
| def testCorruptDeflateDataRaisesZipImportError(self): |
Member
There was a problem hiding this comment.
This test is a bit verbose. I think we can just add it to the existing DeflateCompressedZipImportTestCase, and reuse the helpers there like makeZip() to reduce lots of codes.
Tony123-tech
force-pushed
the
gh-158494-zipimport-corrupt-deflate
branch
from
October 1, 2026 11:12
4add466 to
77e0eb2
Compare
aisk
reviewed
Oct 1, 2026
Tony123-tech
force-pushed
the
gh-158494-zipimport-corrupt-deflate
branch
from
October 2, 2026 09:29
e0b3a3c to
d88bc39
Compare
Contributor
Author
|
All three suggestions applied and squashed to a single commit. Let me know if there's anything else. |
Member
|
Hi @Tony123-tech , according to the Dev Guide, force push should be avoided, so please don't force push in the future. We will use "squash and merge" to merge a PR, so we don't need to squash it before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with test_zipimport (134 tests, 0 failures).