Conversation
edvilme
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
September 21, 2026 21:00
edvilme
added a commit
to microsoft/vscode-python
that referenced
this pull request
Sep 30, 2026
Related python/cpython#157932 Related #25467 Modifies `_pyrepl.utils.ANSI_ESCAPE_SEQUENCE` to correctly support VSCode's OSC sequences and prevent cursor misplacing when using the REPL inside vscode. Refactorings for easier maintainability
brettcannon
requested changes
Oct 1, 2026
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve how PyREPL detects and handles OSC (Operating System Command) sequences so that they are properly recognized and accounted for when calculating string widths and rendering lines.
Enhanced the
ANSI_ESCAPE_SEQUENCEregex inLib/_pyrepl/utils.pyto correctly match both CSI and OSC sequences, enabling accurate detection of OSC controls.Before
After