Conversation
configure.ac: Add PY_CHECK_FUNC_PRIVATE() function, similar to PY_CHECK_FUNC() but defines macro _Py_HAVE_xxx instead of HAVE_xxx. Use PY_CHECK_FUNC_PRIVATE() for functions: acospi, asinpi, atanpi, atan2pi, cospi, sinpi and tanpi.
vstinner
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
September 20, 2026 12:12
Member
|
@vstinner, do you suggest to rename all macros, coming from standard configure tests like AC_CHECK_FUNCS_ONCE()? I don't think that they pose some problems for programs, including |
Member
Author
|
My proposition in issue #157695 is to no longer add macros with a name which doesn't start with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.ac: Add PY_CHECK_FUNC_PRIVATE() function, similar to PY_CHECK_FUNC() but defines macro _Py_HAVE_xxx instead of HAVE_xxx.
Use PY_CHECK_FUNC_PRIVATE() for functions: acospi, asinpi, atanpi, atan2pi, cospi, sinpi and tanpi.
Py#157695