gh-157782: Fix test_ttk for Tk 9.1b1 and 9.0.5 - #157783
Merged
serhiy-storchaka merged 1 commit intoSep 19, 2026
Merged
Conversation
The empty string is now accepted for -justify of ttk::entry, ttk::combobox and ttk::spinbox, and for -anchor of ttk::label.
serhiy-storchaka
added
skip news
needs backport to 3.15
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-157823 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-157824 is a backport of this pull request to the 3.14 branch. |
|
GH-157825 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Tk ticket aba849a99b the empty string is the default of
-justifyofttk::entry,ttk::comboboxandttk::spinbox, and of-anchorofttk::label, and means the theme default. The tests checked that it is rejected. The change is in Tk 9.1b1 and will be in Tk 9.0.5, hence the(9, 0, 5)gate.Tested with Tk 8.6.17, 9.0.3, the current core-9-0-branch (9.0.5) and 9.1b1.