Skip to content

gh-144712: Export _Py_jit_entry symbol via PyAPI_DATA - #145840

Merged
diegorusso merged 5 commits into
python:mainfrom
ashm-dev:gh-144712
Sep 17, 2026
Merged

diegorusso merged 5 commits into
python:mainfrom
ashm-dev:gh-144712

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jjhelmus does this fix your problems?

@Fidget-Spinner

Copy link
Copy Markdown
Member

@diegorusso does this look right to you?

@diegorusso

Copy link
Copy Markdown
Contributor

Please hold on that. This #146071 needs to go in first and likely this needs to be adapted.

@ashm-dev

Copy link
Copy Markdown
Contributor Author

@diegorusso #146071 was merged on 2026-05-02. I've rebased onto current main and adapted the initializer (_PyJIT_PyJIT_Entry). Could you take another look? @Fidget-Spinner the change is small enough that your earlier approval should still apply — pinging in case you'd like to re-confirm before merge.

@ashm-dev

Copy link
Copy Markdown
Contributor Author

The Ubuntu (free-threading) / build and test failure is unrelated — the runner received a shutdown signal mid-run (exit code 143, "runner has received a shutdown signal"). All tests passed up to that point. A rerun should be green.

@ashm-dev

Copy link
Copy Markdown
Contributor Author

@Fidget-Spinner @diegorusso, could you please take another look?

@ashm-dev

Copy link
Copy Markdown
Contributor Author

@diegorusso #146071 landed in May, this PR is rebased on top of it. Can the hold be lifted? @Fidget-Spinner your approval still stands, could you merge once Diego confirms?

@Fidget-Spinner

Copy link
Copy Markdown
Member

I'm waiting for Diego.

Comment thread Python/ceval.c
@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ashm-dev

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @diegorusso: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from diegorusso September 11, 2026 18:13

@diegorusso diegorusso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM now.

@diegorusso
diegorusso merged commit e8c06d6 into python:main Sep 17, 2026
76 of 77 checks passed
@diegorusso

Copy link
Copy Markdown
Contributor

Thanks, even though the JIT development is paused, this counts as bugfix which is allowed hence merging.

@ashm-dev
ashm-dev deleted the gh-144712 branch September 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants