Skip to content

Consider square brackets when building call_stack - #1336

Open
denyshon wants to merge 1 commit into
python-babel:masterfrom
denyshon:consider-square-brackets
Open

denyshon wants to merge 1 commit into
python-babel:masterfrom
denyshon:consider-square-brackets

Conversation

@denyshon

@denyshon denyshon commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This PR adds [ and ] to values for which call_stack.append and call_stack.pop are called in extract_python.

@akx akx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see some tests, please!

@denyshon
denyshon force-pushed the consider-square-brackets branch from 995cfb8 to 7ad63c9 Compare September 19, 2026 13:31
@denyshon
denyshon force-pushed the consider-square-brackets branch from 7ad63c9 to f2272e3 Compare September 19, 2026 13:32
@denyshon

Copy link
Copy Markdown
Contributor Author

@akx I've added a couple of test cases to the existing test_invalid_filter. Hopefully, this should cover the changes in this PR

@denyshon
denyshon requested a review from akx September 19, 2026 13:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python extractor treats dict arguments as literal strings

2 participants