Conversation
garyb
approved these changes
Sep 22, 2026
garyb
left a comment
Member
There was a problem hiding this comment.
Absolutely, good catch! Surprised it's taken anyone this long to notice 😄
Author
|
Thanks! Felt like a déjà vu of #14 🔁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
relativeis typed as a pure function, but Node'spath.relativeresolves both of its arguments againstprocess.cwd()before computing the relative walk. Whenever either argument is a relative path, the result therefore depends on the working directory at the time of the call:This is the same reasoning that moved
resolveintoEffectin #14 (see also #4 and the discussion in #20).path.relativecallspath.resolveinternally and inherits the dependence, but its signature was never updated.This PR changes
relativetoFilePath -> FilePath -> Effect FilePath, with the FFI written the same way asresolve. The doc comment now mentions the working-directory dependence, and the existing test is adjusted to bind the result.This is a breaking change and will need a major version bump.
Checklist:
relativetest was updated for the new type; no new test was added, matchingresolveis impure #14.