Repository navigation
Upgrade GCC 13.2.0 version (PPU-SPU) - #121
humbertodias wants to merge 160 commits into
Conversation
|
Hey cool work, I really want gcc 13 on ps3. But you just forgot to credit Darjan Krijanand and luizfernandonb :/ |
Yeah.. I left his name on patch's file given him the credit |
|
GCM samples from PSL1GHT should be compiled with the update because if I remember correctly, GCM stuff wasn't working well when I tested when the PR was created. |
|
On my PS3 Moonlight project i compiled pr for myself. I didn't see any problems with that, my project utilized Tiny3D for display. |
|
Tested with SoRR bennug64-port-ps3.mp4 |
|
@humbertodias Your gcc updates have been merged through the gcc-PS3 repository. |
Keep split PPU/SPU/host patches and gcc-PS3 PPU delta (no TARGET_USES_LINUX64_OPT). Take master's newlib dirent sentinels and SPU --with-newlib/--with-pic.
The upstream merge left a cat of gcc-9.5.0-PS3.patch; SPU already uses the -SPU/-host/-macos-arm64 patches.
Sure! master branch merged into this PR |
Keep split GCC patches; also refresh newlib config.guess/config.sub and keep SPU --with-system-zlib.
The last master merge applied those hunks to gcc-13.2.0-PS3-PPU.patch; they already exist in GCC 13 and make GNU patch fail on Linux after zlib.
thanks for all your efforts here @humbertodias 👍 I've triggered the CI checks to confirm everything builds ok. Please follow up with zeldin if you have questions or need another review. 🙏 |
This reverts commit ec5410b.
|
Could the docker ci be skipped for pull requests? |
…h # fails closed in a few seconds when those secrets are unavailable
Sure! Skipped 6f580ea |
|
So, looking at the current "Files changed" for this PR, there are a few unrelated changes here:
These should be made into separate PRs so that they can be reviewed and merged (if appropriate). In addition there's a bunch of other stuff which I don't think is relevant, like the utils functions to handle Kitchen sink PRs like this one can be useful to try get some testing of a complete set of changes, but they are not conductive to actual merging. 😸 |
GDB was causing issues building on macOS from what I remember and users can install GDB-Multiarch to get the same result, we also have no way to actually use GDB outside RPCS3 from what I know. I can look into restoring it. |
Sounds like a better solution would be to fix the build issues then. Probably there is some upstreams commit that can be backported. GDB should be able to interact with |
|
@magendavid06-cell I do not believe that this should be merged without significant cleanup. This PR has 160 commits with changes to 26 files, none of which are needed to actually implement what the PR says it is for (because that has already gone in though PRs in other repos). Merging this will put the main repo in a very confusing state. I'm not (at the moment at least 😸) objecting to any specific change still contained in this PR, I'm just saying that the different changes should be squashed and re-published as separate PR:s so that they can be properly reviewed and cleanly merged. (sorry, had the wrong Github user active at first...) |
|
@zeldin This person created their account a few hours ago just to approve the changes with no comments. I didn't even know someone could do that until now. I would probably disregard it entirely. That said, this probably is a reminder this is an important item to raise and get some motion on. I agree with the three separated PRs you mentioned earlier - am I right in saying the next step is we make those PRs, strip out the extraneous features from this one, and then return to this one for a review of GCC? It seems like the core work is done, it just needs procedure. |
|
@TheMrIron2 The GCC stuff is already done; it was reviewed and merged as ps3dev/gcc-PS3#1. If there is any fallout from it we can handle it with new issues/PRs, I don't think there is any benefit in remitting to this PR. If any input from humbertodias is needed we can tag him. As for the other changes, yes, I'd say the next step is to make new PR:s. It's a little bit of extra work but it will make the scope of each change clear so that it can be reviewed, tested and merged in isolation. I don't think there are any cross-dependencies. If humberodias doesn't have the time or energy to do it, it's possible for someone else to pick up the torch; we can still give proper credit in the author field. |
Features
Note
We've selected the version 9.5.0 because it's the last GCC release to include support for SPU.
https://www.phoronix.com/news/GCC-10-Drops-Cell-BE-SPU
Tip
Patches credits to disc-kuraudo and luizfernandonb
Result
https://github.com/humbertodias/ps3toolchain/actions/runs/8166663270
Note
Don't forget to create a named DockerHub environment on your repository with two secret variables: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN
badges

PSL1GHT hello game