Repository navigation
mx4sio: resume partial transfers at the next sector - #936
Open
PS2HomeDeveloper wants to merge 2 commits into
Open
PS2HomeDeveloper wants to merge 2 commits into
PS2HomeDeveloper wants to merge 2 commits into
Conversation
## Summary Fix the sector position used by MX4SIO when retrying a partially completed multi-sector transfer. After a partial read or write, the driver advances the buffer to the remaining data but previously reused the original starting sector for the next CMD18 or CMD25 attempt. This could cause a retry to process the wrong sectors. Advance the sector position by the number of sectors already transferred. For writes, also pass the remaining sector count to the multi-block write setup so the ACMD23 pre-erase hint matches the remaining request. This does not change the public API or the successful full-transfer path. ## Testing - Built the MX4SIO module with the PS2SDK toolchain. - [Add the PS2/MX4SIO and SD-card tests actually performed, if available.] A deterministic partial-transfer hardware-failure test was not available.
Fix missing newline at the end of the file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the sector position used by MX4SIO when retrying a partially completed multi-sector transfer.
After a partial read or write, the driver advances the buffer to the remaining data but previously reused the original starting sector for the next CMD18 or CMD25 attempt. This could cause a retry to process the wrong sectors.
Advance the sector position by the number of sectors already transferred. For writes, also pass the remaining sector count to the multi-block write setup so the ACMD23 pre-erase hint matches the remaining request.
This does not change the public API or the successful full-transfer path.
Testing
A deterministic partial-transfer hardware-failure test was not available.