Fix conversion of matplotlib contour lines - #5770
Open
robertoffmoura wants to merge 5 commits into
Open
robertoffmoura wants to merge 5 commits into
robertoffmoura wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpl_to_plotlydoesn't render contour lines correctly. Matplotlib packs each contour level into a single path containing several disjoint subpaths, so the converted figure connects them with segments that shouldn't exist, and closed rings are left open because theCLOSEPOLYvertex is dropped on export:Fix: path collections with no face colors (line collections, which is what
ax.contourproduces) are now drawn as line traces instead of filled polygons:None, so plotly does not connect themZcode have their first vertex appended to close the ringC,S) consume the correct number of vertices while parsingSnippet to reproduce: