Conversation
Contributor
Author
|
You're right, my original constraint was too strict. I agree that a non-final class can represent an open branch of the hierarchy, even if it is not itself a subtype of the annotated type. I relaxed the validation accordingly: PHPStan now reports an error only when a listed final class or enum is not a subtype of the annotated type. I also added regression tests covering both the valid non-final branch and the invalid final-class case. I also agree that this should be introduced in bleeding edge, and added the check there. |
VincentLanglet
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that every type listed in
@phpstan-sealedis a subtype of the annotated class or interface.Invalid entries are reported with the
sealed.notSubtypeerror identifier.Add regression coverage for valid and invalid enum, interface, abstract-class, and final-class sealed subtype declarations, including the reflexive case.
Closes #15204