Skip to content

FPM: fix memory bugs in fpm_status.c #23833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1ma wants to merge 3 commits into
base: PHP-8.4
Choose a base branch
from
+47 −1
Open

FPM: fix memory bugs in fpm_status.c #23833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09c54e0
fpm: fix potential null dereference in fpm_status_export_to_zval()
1ma Sep 21, 2026
92ba388
fpm: fix a use-after-free of scoreboard_p
1ma Sep 23, 2026
cfad1b4
fpm: fix _GET_str memory leaks and test headers_only status path
1ma Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sapi/fpm/fpm/fpm_status.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ int fpm_status_export_to_zval(zval *status)
int i;

scoreboard_p = fpm_scoreboard_copy(NULL, 1);
if (!scoreboard_p) {
return -1;
}

now_epoch = time(NULL);
fpm_clock_get(&now);
Expand Down Expand Up @@ -180,17 +183,19 @@ int fpm_status_handle_request(void) /* {{{ */
sapi_add_header_ex(ZEND_STRL("Expires: Thu, 01 Jan 1970 00:00:00 GMT"), 1, 1);
sapi_add_header_ex(ZEND_STRL("Cache-Control: no-cache, no-store, must-revalidate, max-age=0"), 1, 1);
PUTS("Internal error. Please review log file for errors.");
zend_string_release_ex(_GET_str, 0);
return 1;
}

if (scoreboard_p->idle < 0 || scoreboard_p->active < 0) {
fpm_scoreboard_free_copy(scoreboard_p);
zlog(ZLOG_ERROR, "[pool %s] invalid status values", scoreboard_p->pool);
SG(sapi_headers).http_response_code = 500;
sapi_add_header_ex(ZEND_STRL("Content-Type: text/plain"), 1, 1);
sapi_add_header_ex(ZEND_STRL("Expires: Thu, 01 Jan 1970 00:00:00 GMT"), 1, 1);
sapi_add_header_ex(ZEND_STRL("Cache-Control: no-cache, no-store, must-revalidate, max-age=0"), 1, 1);
PUTS("Internal error. Please review log file for errors.");
zend_string_release_ex(_GET_str, 0);
fpm_scoreboard_free_copy(scoreboard_p);
return 1;
}

Expand All @@ -201,6 +206,7 @@ int fpm_status_handle_request(void) /* {{{ */

/* handle HEAD */
if (SG(request_info).headers_only) {
zend_string_release_ex(_GET_str, 0);
Comment thread
1ma marked this conversation as resolved.
fpm_scoreboard_free_copy(scoreboard_p);
return 1;
}
Expand Down
40 changes: 40 additions & 0 deletions sapi/fpm/tests/status-head.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
--TEST--
FPM: Status HEAD request returns headers without body
--SKIPIF--
<?php include "skipif.inc"; ?>
--FILE--
<?php

require_once "tester.inc";

$cfg = <<<EOT
[global]
error_log = {{FILE:LOG}}
[unconfined]
listen = {{ADDR}}
pm = static
pm.max_children = 1
pm.status_path = /status
EOT;

$tester = new FPM\Tester($cfg);
$tester->start();
$tester->expectLogStartNotices();
$tester->request()->expectEmptyBody();

$response = $tester->request(uri: '/status', method: 'HEAD');
$response->expectEmptyBody();

$tester->terminate();
$tester->expectLogTerminatingNotices();
$tester->close();

?>
Done
--EXPECT--
Done
--CLEAN--
<?php
require_once "tester.inc";
FPM\Tester::clean();
?>
Loading