Fix GH-23764: Built-in server leaks fd on HEAD request for static file - #23765
Open
jakubskopal wants to merge 1 commit into
Open
jakubskopal wants to merge 1 commit into
jakubskopal wants to merge 1 commit into
Conversation
ndossche
reviewed
Sep 19, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Perhaps an even better fix is to avoid the open call and only rely on the stat call from earlier. What do you think?
jakubskopal
force-pushed
the
fix-gh-23764
branch
from
September 21, 2026 08:41
fa9fdb7 to
a31ded7
Compare
…file php_cli_server_begin_send_static() opens the file, but for HEAD requests never stores the descriptor in client->file_fd, so nothing closes it. Do not open the file for HEAD at all: no body is sent and Content-Length comes from the stat done during path translation. Only check that the file is readable with access(R_OK), so HEAD still returns 404 in the same cases GET does.
jakubskopal
force-pushed
the
fix-gh-23764
branch
from
September 21, 2026 08:43
a31ded7 to
91c79b1
Compare
Author
|
Have a look. I've amended the commit. HEAD should theoretically return the same status as GET, so one needs to check permissions to be able to do that (open not only opens, but also checks readability). I'm not sure one saved call (open+close vs. access) is worth the 10 lines added. Let me know which one you prefer. I personally would prefer the former. |
Member
|
Yeah okay, you're right. Please go back to the original solution and I'll approve. Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-23764.
php_cli_server_begin_send_static()opens the file, but for HEAD requests never stores the descriptor inclient->file_fd, so nothing closes it.Rather than closing it right away, do not open the file for HEAD at all: no body is sent and
Content-Lengthcomes from the stat done during path translation. Only check readability withaccess(R_OK)(php_win32_ioutil_accesson Windows), so HEAD still returns 404 in the same cases GET does.Verified with a
--disable-allbuild running as an unprivileged user: after 100curl -Irequests,/proc/<pid>/fdholds 0 references to the served file (previously 100);HEAD /andGET /both 200 with the sameContent-Length; achmod 000file is 404 for both HEAD and GET.Bug exists since 8.2 (#8215); targeting PHP-8.4 as the lowest branch still receiving bug fixes.