editor: add wall-mounted urinal to item catalogs - #889
Open
tripdancer0916 wants to merge 1 commit into
Open
tripdancer0916 wants to merge 1 commit into
tripdancer0916 wants to merge 1 commit into
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: e365562c-90e2-4b03-8159-cafac31afb28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The bathroom catalog has a toilet but no urinal for shared restroom layouts. Add a generic wall-mounted Urinal to both the editor and MCP catalogs, with a 400 × 650 × 350 mm GLB, a transparent catalog thumbnail, and a matching floor-plan image. It uses the existing wall attachment and mounting-height controls, and exposes separate ceramic and drain paint slots.
The mesh is procedurally authored using the generic elliptical-shell approach from
kkg-agentic-bim; no third-party model or texture is included. The Blender generator and asset README document regeneration, dimensions, orientation, and local preview setup.How to test
bun install, thenNEXT_PUBLIC_ASSETS_CDN_URL=http://localhost:3002 bun dev. The override serves the committed assets locally before they are deployed to the normal asset host.urinal; it should return the same dimensions, assets, andwall-sideattachment as the editor catalog.Validation: repository-wide
bun run checkpassed (2,295 files); editor packagebun run check-typespassed; MCPsrc/tools/place-item.test.tspassed (4 tests); Next.js production build passed on Node 24. The build reports a filesystem-tracing warning in the unchanged MCP SQLite store. Local browser verification covered catalog search, placement on both wall faces, mounting-height adjustment, and 2D orientation. The exported GLB bounds, material slots, and catalog parity were also checked.Screenshots / screen recording
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Catalog and static asset additions only; no changes to auth, persistence, or core placement logic beyond a new item entry.
Overview
Adds a generic Urinal bathroom fixture to the editor UI catalog and the MCP built-in catalog, with matching metadata: 0.40 × 0.65 × 0.35 m dimensions, local
/items/urinal/GLB and images,attachTo: 'wall-side', and zero placement offset so mounting height uses existing wall-item controls.Ships committed catalog assets under
apps/editor/public/items/urinal/plus an asset README (dimensions, orientation, material slotsslot_ceramic/slot_drain, regeneration and local CDN preview). A newscripts/generate-urinal.pyBlender 4.5 script procedurally builds the mesh, exportsmodel.glb, and rendersthumbnail.pngandfloor-plan.png—no third-party models or textures.Reviewed by Cursor Bugbot for commit 431981a. Bugbot is set up for automated code reviews on this repo. Configure here.