Conversation
joto
reviewed
Sep 25, 2026
| check(mid); | ||
| } | ||
|
|
||
| // From now on use append mode to not destroy the data we just added. |
Collaborator
There was a problem hiding this comment.
Is there a specific reason why you are running again here in append mode. It seems this doesn't have anything to do with the test we are doing here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where
public-transport.luacurrently fails when run with--slim -x. Issue present since 8d1a55eThe cause is that
set_attributes_on_builderwould get its attribute columns fromoffset + 2, which is correct for ways and relations, but incorrect for nodes. A node that was read back from the middle now would get misaligned columns: it would get a changeset where it expected a timestamp, a uid where it expected a version, and a username where it expected a changeset, that last one having caused the actual crash withillegal changeset: 'marcoh'.Command to reproduce:
osm2pgsql -d ptx -O flex -S public-transport.lua --slim -x ../tests/data/liechtenstein-2013-08-03.osm.pbfLogs currently on master (click to expand)
Logs with this fix (click to expand)