[Dream-814] Milestones in the project timeline widget cannot be opened with a keyboard or screen reader - #25437
Open
bsatarnejad wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Accessible links do not include the repository’s show-on-focus mixin, so they remain visible and in normal flow.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds keyboard- and screen-reader-accessible links for timeline milestones and sprints, with visual highlighting of focused items.
Changes:
- Adds accessible milestone and sprint URLs.
- Highlights corresponding timeline items on focus.
- Updates tooltip accessibility and related tests/styles.
File summaries
| File | Description |
|---|---|
project-timeline-tooltip.popover.ts |
Hides tooltip content from assistive technology. |
project-timeline-item.builder.ts |
Builds accessible links for milestones and sprints. |
project-timeline-graph.component.ts |
Adds focus highlighting and item navigation. |
project-timeline-graph.component.html |
Renders accessible timeline links. |
project-timeline-graph.component.sass |
Styles links and highlighted items. |
project-timeline-graph.component.spec.ts |
Tests accessible links and highlighting. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
+23
| &--accessible-link | ||
| top: var(--base-size-8) | ||
| left: var(--base-size-8) | ||
| padding: var(--base-size-4) var(--base-size-8) | ||
| border-radius: var(--borderRadius-default) | ||
| background: var(--bgColor-default) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/DREAM-814
What are you trying to accomplish?
Render milestone and sprint as links in the accessible timeline widget. Reveal focused links for sighted keyboard
users and highlight their corresponding visual timeline items.
Screenshots