Skip to content

[RESMA-76] Global Resource Management (3/6) - #25432

Open
klaustopher wants to merge 2 commits into
RESMA-67-part-2from
RESMA-67-part-3
Open

klaustopher wants to merge 2 commits into
RESMA-67-part-2from
RESMA-67-part-3

Conversation

@klaustopher

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/projects/RESMA/work_packages/RESMA-67/activity

What are you trying to accomplish?

  • Update all routes used in resource management to use project or global routes depending on the ResourcePlanner's scope

Screenshots

What approach did you choose and why?

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher
klaustopher added this pull request to stack #25430 September 17, 2026 16:31
@klaustopher klaustopher changed the title [RESMA-76] Global Resource Management (3/x) - #25427 [RESMA-76] Global Resource Management (3/6) Sep 17, 2026
@klaustopher
klaustopher marked this pull request as ready for review September 17, 2026 18:00
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]
  • rspec ./spec/features/roles/report_spec.rb[1:1]
  • rspec ./spec/features/roles/report_spec.rb[1:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25432, linked for reference only):

- `rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]`
- `rspec ./spec/features/roles/report_spec.rb[1:1]`
- `rspec ./spec/features/roles/report_spec.rb[1:2]`

Treat this as a standalone task, unrelated to PR #25432. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25432 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @klaustopher to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @klaustopher, and request a review from @klaustopher.
On every commit, set @klaustopher as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

controller: "resource_management/resource_planner_views",
only: %i[show new create edit update destroy]
only: %i[show new create edit update destroy] do
member do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to nest the existing routes in an optional scope for the project, like we did with the type variants. That DRYs up the routes and remove all string substitution necessity.

A tentative PR is worth a thousand words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants