test: add missing assertions for run functions - #1739
Closed
Dinesh-5445 wants to merge 1 commit into
Closed
Dinesh-5445 wants to merge 1 commit into
Dinesh-5445 wants to merge 1 commit into
Conversation
AtharvaManale
left a comment
AtharvaManale
left a comment
There was a problem hiding this comment.
Fold_Evalution Runtime validation/assert
| ) | ||
|
|
||
| # todo: check if runtime is present | ||
| assert "usercpu_time_millis" in run.fold_evaluations |
There was a problem hiding this comment.
theres no need for this cause bellow _check_fold_timing_evaluations() function validates it.
Collaborator
|
Hi, thanks for taking the time to contribute, but it seems like this is a duplicate of #1658. We'll move forward with that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
This PR adds the missing assertions requested in issue #1646 to
tests/test_runs/test_run_functions.py.The added assertions verify that:
usercpu_time_millis) is present in the fold evaluations.These assertions strengthen the existing tests by checking that the expected run metadata and artifacts are properly populated.
No new files or documentation were added, and no unrelated code was changed.
All pre-commit checks passed, including Ruff, Ruff format, mypy, and the repository validation hooks.