Say in the README that the CLI has no style flag - #85
Merged
Merged
Conversation
The palantir-to-open table still paired --palantir with --ojf and -ojf, but since 2.98.0.2 the command line formats in the one style without a flag. --ojf and -ojf are only accepted for old scripts: the formatter prints a warning to remove them and formats as usual, while --palantir stops it with exit code 2. The row now says there is no flag, in the words the site's Migrate page uses. Checked with the 2.98.0.4 command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The palantir-to-open table in the README pairs
--palantirwith--ojfand-ojf, as if the commandline still needed a style flag. It has not since 2.98.0.2: it formats in the one style without a flag.
After this PR
==COMMIT_MSG==
The README says the command line has no style flag.
--ojfand-ojfare only accepted for oldscripts: the formatter prints a warning to remove them and formats as usual, while
--palantirstops it with exit code 2. The row uses the words of the site's Migrate page, "none: there is one
style".
==COMMIT_MSG==
Checked with the 2.98.0.4 command line. The site already says the same on Migrate and Command line;
nothing else in the repository's docs names a style flag.
Possible downsides?
None: the row only describes what the command line has done since 2.98.0.2.