Skip to content

Measure the whole type of a cast before inlining a chain onto it #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abashev merged 2 commits into from
Sep 25, 2026
+95 −4
Merged

Measure the whole type of a cast before inlining a chain onto it #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b58f5c6
Measure the whole type of a cast before inlining a chain onto it
abashev Sep 25, 2026
d564203
Give the cast golden an input that has to be laid out afresh
abashev Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,10 +678,18 @@ public Void visitBreak(BreakTree node, Void unused) {
@Override
public Void visitTypeCast(TypeCastTree node, Void unused) {
sync(node);
builder.open(
plusFour,
BreakBehaviours.preferBreakingLastInnerLevel(true),
LastLevelBreakability.ACCEPT_INLINE_CHAIN);
// An inline chain that ends at this level must have room for the whole type before the break in front of the
// operand. Without IF_FIRST_LEVEL_FITS the chain measured the type up to its first break, the one after the
// "<" of a parameterized type, and once inlined the type itself had to take that break: "(PrivilegedAction<"
// at the end of one line and "String>)" on the next. The type stays breakable for the rare cast that does not
// fit on a line at all.
builder.open(OpenOp.builder()
.debugName("typeCast")
.plusIndent(plusFour)
.breakBehaviour(BreakBehaviours.preferBreakingLastInnerLevel(true))
.breakabilityIfLastLevel(LastLevelBreakability.ACCEPT_INLINE_CHAIN)
.partialInlineability(PartialInlineability.IF_FIRST_LEVEL_FITS)
.build());
token("(");
scan(node.getType(), null);
token(")");
Expand Down
36 changes: 36 additions & 0 deletions ...ources/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.input
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
class TCPTransport {
@SuppressWarnings("removal")
static final Log tcpLog = Log.getLog(
"sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(AccessController.doPrivileged((PrivilegedAction<
String>)
() -> System.getProperty("sun.rmi.transport.tcp.logLevel"))));

static final Level level = LogStream.parseLevel(AccessController.doPrivileged((PrivilegedAction<String>)()->System.getProperty("sun.rmi.transport.tcp.logLevel.and.some.more")));

static final Log methodReference = Log.getLog("sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(
AccessController.doPrivileged(
( PrivilegedAction<String> )
SomeVeryLongClassNameToFillTheLine
:: getTheTcpLogLevelProperty)));

static final Log twoTypeArguments =
Log.getLog("sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(AccessController.doPrivileged((Function< String ,Integer >) s->
System.getProperty("sun.rmi.transport.tcp.logLevel.x"))));

static final Log nested = Log.getLog("sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(AccessController.doPrivileged((Map<String,
? extends List<Integer>>) () -> System.getProperty("sun.rmi.transport.tcp.lv"))));

static final Log qualified = Log.getLog("sun.rmi.transport.tcp", "tcp",
LogStream.parseLevel(AccessController.doPrivileged((java.util.function.
Function<String, Integer>) s -> System.getProperty("sun.rmi.logLevel"))));

static final Log intersection = Log.getLog("sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(
AccessController.doPrivileged((Runnable
&java.io.Serializable) () -> System.getProperty("sun.rmi.transport.tcp.logLevelxx"))));

static final Log annotated = Log.getLog("sun.rmi.transport.tcp", "tcp",
LogStream.parseLevel(AccessController.doPrivileged((Function<@Nullable String, Integer [ ]>)
s -> System.getProperty("sun.rmi.transport.tcp.lvl"))));
}
47 changes: 47 additions & 0 deletions ...urces/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.output
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
class TCPTransport {
@SuppressWarnings("removal")
static final Log tcpLog = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(PrivilegedAction<String>) () -> System.getProperty("sun.rmi.transport.tcp.logLevel"))));

static final Level level = LogStream.parseLevel(AccessController.doPrivileged(
(PrivilegedAction<String>) () -> System.getProperty("sun.rmi.transport.tcp.logLevel.and.some.more")));

static final Log methodReference = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(PrivilegedAction<String>) SomeVeryLongClassNameToFillTheLine::getTheTcpLogLevelProperty)));

static final Log twoTypeArguments = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(Function<String, Integer>) s -> System.getProperty("sun.rmi.transport.tcp.logLevel.x"))));

static final Log nested = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(Map<String, ? extends List<Integer>>) () -> System.getProperty("sun.rmi.transport.tcp.lv"))));

static final Log qualified = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(java.util.function.Function<String, Integer>) s -> System.getProperty("sun.rmi.logLevel"))));

static final Log intersection = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(Runnable & java.io.Serializable) () -> System.getProperty("sun.rmi.transport.tcp.logLevelxx"))));

static final Log annotated = Log.getLog(
"sun.rmi.transport.tcp",
"tcp",
LogStream.parseLevel(AccessController.doPrivileged(
(Function<@Nullable String, Integer[]>) s -> System.getProperty("sun.rmi.transport.tcp.lvl"))));
}
Loading