Cover how a long generic field type wraps - #59
Merged
Merged
Conversation
A field whose parameterized type fits in the line keeps the type whole and moves the name and the initializer to the next line. A type that does not fit breaks right after "<" and puts its arguments one level deeper: on one line when they fit there, one per line when they do not. That is google-java-format's layout, kept as it is. At 120 columns it shows only on a type that is over the limit by itself: in the 15,747 files of the JDK 21 sources, once on a field (LocaleProviderAdapter) and once inside a cast (TCPTransport). The golden pins the three shapes, so that an upstream sync or a change to visitParameterizedType has to say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field whose parameterized type fits in the line keeps the type whole
and moves the name and the initializer to the next line. A type that
does not fit breaks right after "<" and puts its arguments one level
deeper: on one line when they fit there, one per line when they do
not. That is google-java-format's layout, kept as it is. At 120
columns it shows only on a type that is over the limit by itself: in
the 15,747 files of the JDK 21 sources, once on a field
(LocaleProviderAdapter) and once inside a cast (TCPTransport).
The golden pins the three shapes, so that an upstream sync or a change
to visitParameterizedType has to say so.