Name --replace in the error for --dry-run with in-place formatting - #48
Merged
Merged
Conversation
"cannot use --dry-run and --in-place at the same time" named a flag that does not exist: in-place formatting is -i, -r, -replace or --replace (#40, from google/google-java-format#1094). The message now says --replace, the long form the usage text shows. This ports google/google-java-format#1451 by rootkiller6788, including its test for the --replace --dry-run spelling next to -i -n.
abashev
force-pushed
the
dry-run-replace-message
branch
from
September 23, 2026 08:53
3a32861 to
c73a083
Compare
abashev
disabled auto-merge
September 23, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40, split out of #45. Upstream report: google/google-java-format#1094.
From upstream, with the author kept
google/google-java-format#1451 by rootkiller6788 (open upstream), commit authored by them. The error for
--dry-runwith in-place formatting said "cannot use --dry-run and --in-place at the same time", but there is no--in-placeflag: the flag is-i,-r,-replaceor--replace. The message now names--replace, the long form the usage text shows.Checked
CommandLineFlagsTest.inPlaceDryRunchecks both--replace --dry-runand-i -n, and fails on the old message../gradlew :open-java-format:teston JDK 21: 1447 tests, all green.