Conversation
The formatter parses with the javac of the JDK it runs on, so a change can pass on 21 and break on a newer JDK. A new `jdk` job runs the tests of `build` on 25, 26 and 27, in parallel with the other jobs; nothing waits for it. -PjavaRuntime sets baseline's javaVersions.runtime, which moves only the test JVMs: the code is still compiled for Java 21 by JDK 21. The IntelliJ plugin's tests keep the runtime of the IDE they start. `build` keeps JDK 21 and its name, which the ruleset on main requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter parses with the javac of the JDK it runs on, so a change can pass on 21 and break on a newer JDK. This adds a
jdkjob that runs the tests ofbuildon JDK 25, 26 and 27.buildandnative, withfail-fast: false. Nothing waits for them, and nothing they build is kept.-PjavaRuntimesets baseline'sjavaVersions.runtime, which changes only the JVMs the tests run on, and with them javac's internals. The code is still compiled for Java 21 by JDK 21, as in the release. The IntelliJ plugin's tests stay on the JetBrains Runtime of the IDE they start.buildis unchanged. It still runs on JDK 21 and keeps its name, because the ruleset onmainrequires a check calledbuild. The native jobs still wait for it.-Porg.gradle.java.installations.paths.Tested locally:
./gradlew test -PjavaRuntime=25passes: 1410 formatter tests, 22 Gradle plugin tests and 9 IntelliJ plugin tests.-Porg.gradle.java.installations.pathsis honoured on the command line.JDK 26 and 27 are tried only here in CI. Gradle 9.7.1 officially supports Java up to 26, and the Gradle plugin's TestKit builds run Gradle on the test JVM.