Conversation
For iOS, when version 17.4+ is available, check whether the redirect url is a universal link. If it is, use the new init method with callback accepting the universal link.
128a00c to
09cbc59
Compare
w-goog
left a comment
There was a problem hiding this comment.
The README says "Both Custom URI Schemes and Universal Links can be used with the library.". That hasn't been true for a while - thank you for fixing it!
Also, please add "iOS 17.4+, requires the Associated Domains entitlement and an AASA file for the host" to that line of the README :)
|
Thanks for the review! All addressed. I added Also one behavior change to flag: the shared handler checks the result of |
w-goog
left a comment
There was a problem hiding this comment.
Looks good! I updated the language around universal links, since they are technically just HTTPS URLs.
Supersedes #938, rebased onto 3.0.0 and updated for @w-goog's review there.
For iOS 17.4+, when the redirect URL is an HTTPS universal link, use
ASWebAuthenticationSession's HTTPS callback instead of a custom scheme callback.