feat: Only return the grades tab in CCX if gradebook is enabled - #39164
brianjbuck-wgu wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @brianjbuck-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
The CCX Coach v2 metadata endpoint shows the student_grades tab unconditionally.
CCX_COACH_TABSin lms/djangoapps/ccx/api/v2/serializers.py was a static tuple, so the tab was returned even when the gradebook it depends on is not available.The Student Grades experience is backed by the writable gradebook. When either is missing, the Instructor Dashboard MFE still rendered the Student Grades tab that could not work.
Supporting information
Issue: #39148
Testing instructions
Manual:
CUSTOM_COURSES_EDX, set enable_ccx: true on the course, act as the CCX Coach, and create a CCX.WRITABLE_GRADEBOOK_URLis set → student_grades now appears.WRITABLE_GRADEBOOK_URL→ the tab is absent again.Deadline
None
Other information