Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
marked this pull request as ready for review
October 3, 2026 10:59
dschmidt
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Timestamp serialization currently discards valid fractional-second precision.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds search facets to WebDAV REPORT hits using the same XML structure as PROPFIND.
Changes:
- Serializes seven search facet types into XML.
- Adds coverage for facet formatting and escaping.
- Promotes
strcaseto a direct dependency.
| File | Description |
|---|---|
services/webdav/pkg/service/v0/search.go |
Adds generic facet serialization. |
services/webdav/pkg/service/v0/search_test.go |
Tests generated facet XML. |
go.mod |
Promotes the serialization dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2 of 7 tasks
dschmidt
added a commit
to opencloud-eu/web
that referenced
this pull request
Oct 3, 2026
The search REPORT only returns the facets of its hits with opencloud-eu/opencloud#3652. Until that is available the still image time of a video found through the search comes from a file info request.
dschmidt
force-pushed
the
feat/search-report-facets
branch
2 times, most recently
from
October 3, 2026 14:44
a6a7496 to
0e8f883
Compare
The search service returns audio, location, image, photo, video, motion photo and live photo with every hit, the REPORT response dropped them and clients had to PROPFIND each hit. They are now rendered in the xml shape PROPFIND uses, so a client reads both the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search service returns the audio, location, image, photo, video, motion photo and live photo facets with every hit, but the REPORT response dropped them.
The web client needs them in two places:
size - motionPhoto.videoSize.livePhoto.contentId. Without facets in the hit it needs a PROPFIND on top, only to readstillImageTimeUsfor the right start time.The hits now carry the facets in the xml shape PROPFIND uses, rendered generically from the search message, so a client parses both the same way. No proto, index or reva change. A stopgap until the graph search returns driveItems with facets.