fix(search): tika key fixes - #3651
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 100.00% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (a325542) 89111 21640 24.28% Head commit (2282082) 89111 (+0) 21630 (-10) 24.27% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3651) 10 10 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
8403307 to
2282082
Compare
Tika 4 prefixes its metadata keys (mp4:, img:), so the live photo facet was never built there. Live photo support needs tika 4: tika 3 got the video keys only in 3.3.2 and never the still image time. The content key is read through one lookup, marked tika 4 and tika 3 legacy.
Base ISO is a Canon maker note tag holding Canon's raw encoded value, not the iso of the shot: other cameras got no iso, Canon photos a wrong one (256 for an ISO 800 shot). exif:IsoSpeedRatings is there on tika 3 and tika 4.
butonic
left a comment
There was a problem hiding this comment.
Will the code be backwards compatible to tika 4.0?
|
Yes, nothing broke between 4.0 and 4.1. AFAICT they just introduced additional prefixes after my contributions got merged but before 4.0 was released. Every key the PR reads (mp4:com.apple.quicktime.*, img:Content Identifier, quicktime:still-image-time, exif:IsoSpeedRatings, tk:content) is emitted by 4.0.0 under the same name, checked against the /rmeta output of apache/tika:4.0.0-full and 4.1.0 for the same files. What 4.0.0 lacks is unrelated to this change: video:fourcc / audio:fourcc and the embedded video of a motion photo only exist since 4.1.0. One change towards tika 3: the live photo facet now needs tika 4, the unprefixed tika 3 keys are no longer read - but the feature was backported partially only anyway, so it never worked with the Tika 3 series anyway. TL;DR: This does not break anything with Tika 4.0.x that worked before, but it's better to use Tika >= 4.1.x simply because that provides more data that we can make use of |
Includes opencloud-eu/opencloud#3651, which makes the search service read the Tika 4 keys of the live photo facet.
Tika 4 added prefixes to some keys after I upstreamed the features (TIKA-4816).
The extractor now reads the keys that actually made it to the 4.x.x releases.
photo.isocame fromBase ISO, a Canon maker note tag holding Canon's raw encoded value: empty for every other camera, wrong for Canon (256 for an ISO 800 shot). It now comes fromexif:IsoSpeedRatings, which tika 3 and tika 4 both emit.CI and the acceptance compose move from
4.1.0-SNAPSHOT/4.0.0-fullto the releasedapache/tika:4.1.0-full.@kulmann you did the initial photo facet implementation, hence I'm adding you as reviewer :)