Conversation
Signed-off-by: James Ross <james@jross.me> PR-URL: nodejs#64606 Fixes: nodejs#64870 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #66133 +/- ##
=================================================
+ Coverage 90.31% 90.37% +0.06%
=================================================
Files 711 711
Lines 228425 232700 +4275
Branches 43160 44170 +1010
=================================================
+ Hits 206293 210302 +4009
- Misses 14090 14095 +5
- Partials 8042 8303 +261
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #64606 to v24.x.
Refs: #64606
Two conflicts were resolved against
v24.x-staging:src/node_options.h:mainuses theDEFINE_BOOL_FIELDmacro for these fields; v24.x still uses plainbool, so the new field is declared asbool has_run = false;.doc/node.1: dropped. The man page on v24.x has no--runentry to extend (the doc-kit regeneration ofnode.1was never backported), and the same documentation lands viadoc/api/cli.md.Everything else applied cleanly. Verified with a Windows x64 clang-cl release build;
parallel/test-node-runandmessage/node_run_listpass.