Conversation
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66117 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 790 790
Lines 271651 271670 +19
Branches 51842 51850 +8
==========================================
+ Hits 245228 245289 +61
+ Misses 16928 16884 -44
- Partials 9495 9497 +2
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #63848, which appears to have stalled.
When using
--permission,new Socket(fd)would not assert the--allow-netpermission. It needs a bit of special handling to ensure stdio and IPC were handled appropriately.Note: this was reported a while ago as a public PR but we've received multiple, duplicative hackerone reports on this that have been closed as informative. Since there's already a public PR there's no point in not opening this publicly.