Improve splash

[alperozturk96]

Changes

• Uses app logo for splash
• Removes any hardcoded delay for non-branding flow
• No need extend from BaseActivity

Current behavior (master)

When the app starts, the splash screen has two phases:

1. The system shows the splash screen with a blue background.
2. The Activity shows its layout. An ImageView in this layout shows the logo with the text "Nextcloud".

The splash icon and the launcher icon are different items. If you do not set a splash icon, the system uses @mipmap/ic_launcher. This icon is made from ic_foreground and ic_background. You can set a different drawable in windowSplashScreenAnimatedIcon. This does not change the launcher icon but this means brander must override values for this as well.

---

🏚️ Master (1)	🏡 After
1.mp4	2.mp4

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	381e432
Version	17688
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[github-actions]

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/main/java/com/nmc/android/ui/LauncherActivity.kt	66.66%	1 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[AndyScherzinger]

LGTM, one questions though is it still possible to set the headline and subline texts in general, not regarding this PR?

[alperozturk96]

LGTM, one questions though is it still possible to set the headline and subline texts in general, not regarding this PR?

Yes those are didn't deleted https://github.com/nextcloud/android/pull/17688/changes#diff-49701c3de3f691e664e4da47ddfc141e08cf057439becc327dd4a6b00f696d57L33

@tobiasKaminsky Can I test that flow as well from brander for this PR? Or manually configuring setup.xml is enough?

[alperozturk96]

/backport to stable-35.0.x

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	58	58
Dodgy code	185	185
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	26
Performance	37	37
Security	17	17
Total	358	358

[github-actions]

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17688-IT-stable35-08-31