-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Migrate null annotations to jspecify #1066
Copy link
Copy link
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featureenhancementNew feature or requestNew feature or requestready for workThe goal is clear and work towards it can be commencedThe goal is clear and work towards it can be commenced
Description
Activity
Metadata
Metadata
Assignees
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featureenhancementNew feature or requestNew feature or requestready for workThe goal is clear and work towards it can be commencedThe goal is clear and work towards it can be commenced
Currently, the sdk uses Reactor's
reactor.util.annotation.Nullableannotations, such as herejava-sdk/mcp-core/src/main/java/io/modelcontextprotocol/util/Assert.java
Line 28 in fd00498
This is causing warnings in my downstream build since that type refers to javax classes I don't have on the classpath.
This is Reactor Nullable, along with its imports:
The Reactor type is now deprecated, and they recommend you using JSpecify which is fast becoming the standard, if it is not already.
I can possibly submit a PR for this, but I notice a lot of PRs opened recently have limited activity, so will wait for the go-ahead first.