Conversation
larsoner
requested review from
agramfort,
drammock and
mscheltienne
as code owners
September 30, 2026 01:09
Member
Author
|
Fixing a bug where Artemis grads weren't treated as grads in MF for external bases 🤦 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't like that
macoswas creeping up toward 28m runs, so I looked into speeding up our code and tests. There were a number of easy wins:qr+svdvalsinstead of justsvdvalsinestimate_rank. When there are a lot of samples, it's not only faster but slightly more accurate.ranktests (less setup/teardown)pyvista-jsbackend tests popping up web browser tabs 😠gzin a test (saves a few sec)maxwell_filter, project ontor, az, poldirectly rather than onto x/y/z followed by a cart to polarmaxwell_filter, useeighof gram rather than full SVDtime.sleepfor ProgressBar, which only caused up to a1 / 30.s wait, but this really added time to the decoding testslibomp.dyliblibs)These could be split up into separate PRs if needed for review (happy to do it if requested), but the PR is still maybe small enough I think to be reviewable! I think there are Numba replacements we can make that will speed things up further, but I'll do that as a follow-up PR (there are enough of them that it would make this PR too big I think).
These were investigated with Claude Opus 5.5, reviewed and understood by me.