AI: Introduce Perf Police and reusable code review and profiling skills - #776
Merged
Gaurav Sharma (bewithgaurav) merged 9 commits intoSep 24, 2026
Merged
Conversation
Add a repository code-review skill containing the native performance review methodology and verified ownership, profiling, measurement, and runtime-evidence lessons. Expose it through a thin Perf Police custom agent so interactive reviews and other skill-capable reviewers share one rulebook. Correct obsolete execution-path assumptions and distinguish safety requirements from performance optimizations. Profiler operation remains documented in the existing profiler package; no profiler skill or runtime changes are included. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Derive the general code-review skill solely from repository Copilot instructions. Preserve the specialized methodology in performance-code-review and route the Perf Police agent there, keeping normal reviews independent of the performance checklist. Add AI: to the accepted PR title prefixes and align the template, contributor instructions, PR creation guidance, and release-note classification. Reserve the category for AI tooling and development workflows rather than every AI-assisted fix. Existing title categories and description validation remain unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 10, 2026 15:09
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are documentation/automation/agent-skill additions that are internally consistent, low risk, and align CI enforcement with updated contributor guidance.
Pull request overview
Adds reusable GitHub Copilot review guidance to the repo by introducing two Skills (general repository review and performance-focused review), and aligns repository contribution/PR-format documentation and automation to accept the AI: PR-title prefix.
Changes:
- Add
code-reviewandperformance-code-reviewSkills under.github/skills/. - Introduce a thin “Perf Police” custom agent that delegates to the performance Skill.
- Update PR title-prefix validation and contributor-facing guidance/templates to include
AI:(and documentPERF:consistently where applicable).
File summaries
| File | Description |
|---|---|
| CONTRIBUTING.md | Documents AI: as an allowed PR title prefix and clarifies when to use it. |
| .github/workflows/pr-format-check.yml | Updates CI enforcement to accept AI: as a valid PR title prefix. |
| .github/skills/performance-code-review/SKILL.md | Adds an evidence-led performance review methodology Skill for native/perf-sensitive changes. |
| .github/skills/code-review/SKILL.md | Adds a repository-wide review checklist Skill sourced from .github/copilot-instructions.md. |
| .github/PULL_REQUEST_TEMPLATE.MD | Adds AI: to the PR template’s title prefix guidance. |
| .github/prompts/create-pr.prompt.md | Updates the PR-creation prompt to include PERF: and AI: prefixes consistently. |
| .github/copilot-instructions.md | Updates validation-gate guidance to include PERF: and AI: and defines intended AI: usage. |
| .github/agents/release-manager.agent.md | Excludes AI: PRs from customer-facing release notes by default (unless clearly user-visible). |
| .github/agents/perf-police.agent.md | Adds a Perf Police agent definition that points to the performance Skill as the single source of truth. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add an operator skill for the existing Python and native profiler, covering approved environments, build provenance, bounded scenarios, raw result export, timelines, controlled comparisons, and cleanup. Keep instrumented attribution separate from uninstrumented release latency and surface missing prerequisites instead of inventing results. Link the profiler skill from performance review only when new measurements are requested. General repository review, the agent entry point, and the profiler implementation remain unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.1%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 78.4%
mssql_python.pybind.connection.connection_pool.cpp: 82.3%
mssql_python.pybind.connection.connection.cpp: 82.5%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%🔗 Quick Links
|
github-actions
Bot
added
pr-size: large
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 10, 2026 17:50
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are internally consistent across CI validation, contributor docs, templates, and the new skill/agent content, with no runtime-impacting modifications.
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0 new
- Review effort level: Lite
Gaurav Sharma (bewithgaurav)
changed the title
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 16, 2026 05:40
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The profiler skill contains unresolved Release-build and architecture-command issues.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (2)
.github/skills/mssql-profiler/SKILL.md:202
- The uninstrumented comparison command has the same single-config issue as the profiled command:
build.shdoes not configureCMAKE_BUILD_TYPE=Release, so--config Releasedoes not make the resulting macOS/Linux binary a Release/-DNDEBUGbuild. This can make the shipped-latency control incomparable to the profiled build. Make the configure step explicitly select Release here as well.
(cd mssql_python/pybind && ENABLE_PROFILING=0 bash build.sh)
.github/skills/mssql-profiler/SKILL.md:209
- The uninstrumented Windows comparison repeats the same hard-coded
x64target, so an ARM64 base/PR comparison cannot follow the documented procedure. Use the same explicit architecture variable as the profiling build rather than rebuilding a different target.
cmd /c "cd mssql_python\pybind && set ENABLE_PROFILING=0&& build.bat x64"
- **Files reviewed:** 10/10 changed files
- **Comments generated:** 2
- **Review effort level:** Lite
</details>
Gaurav Sharma (bewithgaurav)
marked this pull request as ready for review
September 23, 2026 06:08
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 23, 2026 06:10
View session
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 24, 2026 06:30
View session
Jahnvi Thakkar (jahnvi480)
previously approved these changes
Sep 24, 2026
gargsaumya
previously approved these changes
Sep 24, 2026
Gaurav Sharma (bewithgaurav)
enabled auto-merge (squash)
September 24, 2026 07:02
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 24, 2026 07:27
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved profiler build-configuration and architecture issues, plus a stale skill reference, remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Clarify the source of repository-specific rules for the skill. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Gaurav Sharma (bewithgaurav)
dismissed stale reviews from Jahnvi Thakkar (jahnvi480) and gargsaumya
via
September 24, 2026 07:31
95efea7
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 24, 2026 07:32
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The profiler guidance has unresolved build-configuration and architecture issues that can invalidate profiling results.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (1)
gargsaumya
approved these changes
Sep 24, 2026
Jahnvi Thakkar (jahnvi480)
approved these changes
Sep 24, 2026
Copilot started reviewing on behalf of
Gaurav Sharma (bewithgaurav)
September 24, 2026 08:23
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Add reusable Copilot review guidance while keeping general repository review separate from performance analysis.
code-reviewskill sourced solely from the repository's Copilot instructions.performance-code-reviewskill covering native ownership, performance patterns, benchmark validity, and evidence-based findings.mssql-profilerskill for operating the existing profiler, including build checks, bounded scenarios, raw-data export, timelines, and paired comparisons.AI:PR-title prefix and align the PR template, contribution guidance, and release-note classification.This PR does not change driver runtime behavior.
Validation