Skip to content

.NET: ci/dotnet vscode configuration - #8537

Open
Vincent Biret (baywet) wants to merge 3 commits into
mainfrom
ci/dotnet-vscode-configuration
Open

Vincent Biret (baywet) wants to merge 3 commits into
mainfrom
ci/dotnet-vscode-configuration

Conversation

@baywet

Copy link
Copy Markdown
Member

this is an effort to enable the dotnet extension to work properly in vscode without having to open the dotnet subdirectory. It also adds the test projects to the snlf files. The vscode settings have no impact on people not using vscode, or people using vscode without the dotnet extensions, or people opening the subdirectory with vscode. Right now a bug in the extension is impacting our ability to use this fully. dotnet/vscode-csharp#9787

ci: use the slnf file for dotnet build tasks

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build task bypasses the SDK pinned by dotnet/global.json.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Enables .NET tooling from the repository root in VS Code and expands the release solution filter’s test coverage.

Changes:

  • Adds root-level VS Code .NET settings and build task.
  • Adds unit-test projects to the release solution filter.
File summaries
File Description
dotnet/agent-framework-release.slnf Includes .NET unit-test projects.
.vscode/tasks.json Adds a release solution-filter build task.
.vscode/settings.json Sets the default .NET solution filter.
Review details

Suppressed comments (2)

.vscode/tasks.json:1

  • This new file is missing the required UTF-8 BOM. Please re-save it as UTF-8 with BOM, as required for new .NET-related files by dotnet/AGENTS.md:34-37.
{

.vscode/settings.json:1

  • This new file is missing the required UTF-8 BOM. Please re-save it as UTF-8 with BOM, as required for new .NET-related files by dotnet/AGENTS.md:34-37.
{
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .vscode/tasks.json Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (2 commit(s)): a9cf0a73acd6, 6424ace32abe
Model: gpt-5.6-sol-fast

Overview

The PR adds root-workspace VS Code configuration around the release solution filter and expands that filter with all 32 unit-test projects. The filter is structurally valid, all 67 selected projects exist in the underlying solution, and the fixed process task avoids shell interpolation. However, selecting the release-only graph as the root IDE default leaves samples and integration tests outside the C# project system, so the promised root-folder workflow remains incomplete for contributors working in those projects.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.

Affected areas: .vscode/settings.json

Comment thread .vscode/settings.json
@github-code-quality

github-code-quality Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit c9184b7 in the ci/dotnet-vscode-con... branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main ci/dotnet-vscode-con... c9184b7 +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...SkillsSource.cs 89%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...CopilotAgent.cs 76%
/home/runner/wo...ctionVisitor.cs 70%

Updated September 18, 2026 18:49 UTC

Updated build task to reference the correct solution file and change the working directory.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants