test(tsc): Symlinked projects or the ones with symlinked parents should work - #64473
Open
EVA (Entity Value Attribute) (nikelborm) wants to merge 1 commit into
Open
EVA (Entity Value Attribute) (nikelborm) wants to merge 1 commit into
EVA (Entity Value Attribute) (nikelborm) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
EVA (Entity Value Attribute) (nikelborm)
September 27, 2026 00:18
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The virtual filesystem fix matches os.Chtimes semantics and the focused tests cover the reported regression and relevant symlink variants.
Review effort: Balanced
Findings: None
What changed in this PR
Adds regression coverage for TypeScript builds run from symlinked project paths and updates the test virtual filesystem so Chtimes follows symlinks like os.Chtimes.
Changes:
- Resolve symlinked files and parent directories before updating modification times.
- Add direct
Chtimestests for file and parent-directory symlinks. - Add build scenarios covering real paths, symlinked working directories, parents, and chains.
| File | Description |
|---|---|
tsc/internal/vfs/vfstest/vfstest.go |
Makes virtual Chtimes follow symlinks. |
tsc/internal/vfs/vfstest/vfstest_test.go |
Tests Chtimes symlink behavior. |
tsc/internal/execute/tsctests/tscbuild_test.go |
Adds symlinked-current-directory build regression tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #63819
Along with the addition of the main
TestBuildWithSymlinkedCurrentDirectorytest, I also needed to patchvfstest.go, because otherwise the whole test suite has been throwing 100s of errors. With the patch, only the newly added test intsc/internal/execute/tsctests/tscbuild_test.gois failing. An LLM has been used to help convert the repro from nikelborm/effect-ts7-symlink-repro into a testCaution
The test
TestBuildWithSymlinkedCurrentDirectoryis deliberately failing. It's catching the wrong behavior that's present right now