Stop including API benchmarks in validate - #64337
Merged
Wesley Wigham (weswigham) merged 1 commit intoSep 21, 2026
Merged
Wesley Wigham (weswigham) merged 1 commit into
Wesley Wigham (weswigham) merged 1 commit into
Conversation
Wesley Wigham (weswigham)
requested review from
Andrew Branch (andrewbranch) and
Jake Bailey (jakebailey)
and
a balanced review from Copilot
September 19, 2026 01:43
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Wesley Wigham (weswigham)
September 19, 2026 01:44
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The broader Go benchmark exclusion and conflicting contributor guidance need clarification or correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Separates API benchmark smoke runs from validation and executes them through dedicated tasks.
Changes:
- Removes benchmarks from API tests.
- Adds a standalone API benchmark task and CI step.
- Excludes benchmark tasks from
validate.
| File | Description |
|---|---|
| packages/typescript/test/sync/api.test.ts | Removes sync benchmark execution. |
| packages/typescript/test/sync/api-generators.test.ts | Removes generator benchmark execution. |
| packages/typescript/test/async/api.test.ts | Removes async benchmark execution. |
| Herebyfile.mjs | Adds API benchmark orchestration and changes validation behavior. |
| .github/workflows/ci.yml | Runs API benchmarks as a dedicated CI step. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Andrew Branch (andrewbranch)
approved these changes
Sep 21, 2026
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
I had the same thought last week. I agree that the benchmarks shouldn't add any actual coverage over the rest of the test suite.
Jake Bailey (jakebailey)
approved these changes
Sep 21, 2026
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
So long as CI still checks it, I think it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They get their own test subtask executed in CI instead of being run directly in the main API tests, similar to how the
gobenchmarks already work.