Fix CI for older distros - #342
Merged
Merged
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rolling #342 +/- ##
========================================
Coverage 54.68% 54.68%
========================================
Files 102 102
Lines 5918 5918
Branches 944 944
========================================
Hits 3236 3236
Misses 2347 2347
Partials 335 335 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
David-LP99
added a commit
that referenced
this pull request
Sep 23, 2026
Includes cherry-picks of #305 and #342 (which fixes the CI for older distros) Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99
added a commit
that referenced
this pull request
Sep 23, 2026
Includes cherry-picks of #305 and #342 (which fixes the CI for older distros) Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99
added a commit
that referenced
this pull request
Sep 23, 2026
Includes cherry-picks of #305 and #342 (which fixes the CI for older distros) Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the previous version,
ros2 runwas in charge of the agent, but injazzyandhumbleit doesn't forward the SIGTERM, so the agent is not killed at the end of every step that needs it. The binary is executed directly instead.