Fix Azure Unicode metadata round trips (10.0.14) - #122
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 50.14% 50.33% +0.18%
==========================================
Files 163 164 +1
Lines 8076 8112 +36
Branches 1071 1082 +11
==========================================
+ Hits 4050 4083 +33
+ Misses 3563 3560 -3
- Partials 463 469 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure uploads fail when logical metadata contains a Unicode filename such as
матеріал.txt, because those values are emitted directly as HTTP headers. The provider now encodes metadata requiring transport conversion in one versioned ASCII envelope and restores the original dictionary across portable upload/download/listing, conditional object, multipart and container operations.Native ASCII metadata remains interoperable. Reserved-key collisions and malformed envelopes are covered, while content bytes, exact retry comparison and ETag conditions retain their existing behavior. The canonical package patch version is 10.0.14.
Validation: the unchanged provider failed 3 of 4 initial real-Azurite cases. After repair, 39 focused provider tests passed; the required non-BrowserStress suite passed 498 tests with 3 existing skips (501 total), including all six final metadata cases. Canonical solution formatting passed and the Release solution build finished with zero warnings and errors.