Repository navigation
fix(teams): recognize reaction shortcuts and Like activation - #141
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams activation recognized the bare Heart eyes robot ID but rejected its picker shortcut spelling,
:hearteyesrobot:. Intake now accepts safe paired-colon shortcuts, and adds the standard Like reaction (likeor Unicode thumbs up, including skin tones) as an alternative activation. Help retains Heart eyes robot as the primary picker choice and documents Like.New aliases use a persisted introduction cutoff in the existing Graph subscription record. This prevents a previously ignored reaction from activating on a later unrelated update. Subscription reuse, context refresh and restarts preserve the cutoff; missing cutoff fails closed only for new aliases. Existing bare robot/control admission and dedup identities remain intact.
Validation: 79 focused tests passed, zero failures/skips, covering native/Graph shortcut and Like dispatch in personal/group/channel sessions, reactor authorization, removal handling, old-history suppression and cutoff persistence. Independent review identified the replay issue and found no blocking defects after correction. Static check passed (798 JavaScript files), secret scan clean (1120 files/blobs), DCO passed. Live Teams event delivery and required personal QA registry cases remain pending; the failed message link has been requested and no live trigger success is claimed.