Repository navigation
fix(teams): show Teams reaction names and IDs in help - #140
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams help displayed Slack shortcodes and a plain robot beside the Heart eyes robot label. The guide now uses Teams picker names with the actual reaction IDs in both the native card and its text fallback, and explains that sending an ID as text does not add a reaction. Heart eyes robot is identified by its picker name without substituting an unrelated Unicode icon.
Validation: 30 focused help/control/card tests passed, zero failures or skips. Static check passed for 798 JavaScript files; secret scan clean for 1120 files/blobs; DCO passed. Existing tests verify separate reaction rows, preserved guide content and message budget, and exclude Slack shortcodes and the mismatched icon. Live Teams display and private QA registration remain pending; the requester’s required personal QA connection is unavailable.