Repository navigation
Enable Teams stop and reminder acknowledgment emoji actions - #139
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams ignored Stop sign and Tick button reactions, while its robot reaction could start a request. Stop sign now cancels the selected session’s active and queued requests using the same author/admin guard as
/stop. Tick button acknowledges a tracked reminder from its original or escalation notice. Reaction removal cannot reopen an acknowledged reminder; ordinary messages report no pending reminder.Native and Graph intake recognize Microsoft’s
stopsignand2705_whiteheavycheckmarkIDs alongside existing robot IDs and Unicode aliases. Controls pass reactor authorization and the sudo gate before mutation; target text cannot dispatch slash commands. Reply mappings resolve native channel reply reactions to their source session. Graph history uses only the latest current transition, suppresses removed/ambiguous combined flags, distinguishes new control event identities and preserves existing robot/edit dedup IDs across upgrade. Help and the Teams guide describe the actions and event-delivery prerequisites.Validation: 77 focused tests pass with zero failures/skips; static checks, secret scanning and DCO pass. Native/Graph stop cases cover personal, group and channel sessions, queued cancellation, ownership/admin scope and unrelated session isolation. Native/Graph Tick cases cover original/escalation reminders, authorization/sudo denial and no engine dispatch. Independent review checked routing, authorization and Graph flags handling.
A broader regression run passed 257 of 258 tests. Its sole failure is the existing
platform-voice.test.jsexact-output assertion: actual output includes the statistics footer. The same failure reproduces on unchanged beta.Live Claude/Codex Teams tests and private Airtable QA registration remain unexecuted. TEST-PLAN.md contains exact fixture/actions/pass rules. The available Teams connection belongs to a different account; a permitted QA conversation is still requested. The requester’s personal Airtable connection is unavailable and was not substituted.