Skip to content

SP-3336: NB 203-series on the skymap - #213

Merged
jeffcarlin merged 2 commits into
mainfrom
tickets/SP-3336
Sep 16, 2026
Merged

jeffcarlin merged 2 commits into
mainfrom
tickets/SP-3336

Conversation

@jeffcarlin

Copy link
Copy Markdown
Collaborator

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@galaxyumi
galaxyumi self-requested a review September 11, 2026 22:47
Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
@@ -0,0 +1,738 @@
{

@galaxyumi galaxyumi Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add assert tap_service is not None to be consistent with the text in the cell above.


Reply via ReviewNB

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've decided that these asserts are no longer needed.

Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
@@ -0,0 +1,738 @@
{

@galaxyumi galaxyumi Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure caption is missing.


Reply via ReviewNB

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I always forget to add those!

Comment thread DP2/200_Data_products/203_Maps/203_2_The_skymap.ipynb
@@ -0,0 +1,738 @@
{

@galaxyumi galaxyumi Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure caption is missing.


Reply via ReviewNB

@@ -0,0 +1,738 @@
{

@galaxyumi galaxyumi Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to include a quick demonstration showing how to access cell boundaries, similar to the tract and patch examples in the previous sections.


Reply via ReviewNB

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea -- done!

@galaxyumi galaxyumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff for this nice tutorial! I left some minor and major comments.

@galaxyumi galaxyumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a new tutorial!

@jeffcarlin
jeffcarlin merged commit 7f86303 into main Sep 16, 2026
2 checks passed
@jeffcarlin
jeffcarlin deleted the tickets/SP-3336 branch September 16, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants