Repository navigation
Polish download defaults and align CLI configuration - #418
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the default simultaneous download limit from 2 to 4 and the per-host download limit from 8 to 16, keeping 4 connections per download. Explicit saved settings remain respected.
Make the CLI use the shared download defaults, align the generated TOML template and documentation, and clarify that the per-host limit counts downloads rather than connections. Add regression coverage for CLI fallback and template consistency.
Validation: 480 tests passed across the configuration and core JVM suites and CLI argument parsing:
./gradlew :config:jvmTest :library:core:jvmTest :cli:test --tests '*DownloadArgsTest' -PprebuiltWebDir=/tmp/ketch-no-web-assets -PtestBuildRevision=ci-test